targetframework net5.0 #2452
targetframework net5.0 #2452
Conversation
|
@vip32 that is a good start, but we need to run the tests against net5.0 as well, we need also to adjust the build to run the docker images to test the artifacts as well as build docker images targeting .net5.0 |
|
@vip32 Sounds great. |
|
@digitalsigi, click the green checkmark next to the commit you'd like to download and you will be taken to GitHub Actions where you can find the built artifacts for that particular build:
|
|
@arturcic anything needs to be done in the docker testing department? can't find where i can specify the netversions for the various docker tests |
We need to build new base images to be able to test - here is the source code Then we need to adjust the azure pipelines GitVersion/azure-pipelines.yml Line 62 in 26def75 GitVersion/azure-pipelines.yml Line 74 in 26def75 and GitHub actions GitVersion/.github/workflows/build.yml Line 106 in 26def75 GitVersion/.github/workflows/build.yml Line 236 in 26def75 |
|
should 5.0 be added here, or replace the 3.1 |
2.1 was removed some time ago to speed up the build time. We might consider dropping support for 2.1 and just keep 3.1 and 5.0 |
|
ok, am stuck. the (docker)test errors don't make clear what is missing |
I think not docker is the issue, as you don't get to those step yet. Seems like there is an issue with nunit and .net5.0 |
locally the .net5 nunit tests run fine |
Codecov Report
@@ Coverage Diff @@
## master #2452 +/- ##
=======================================
Coverage 78.05% 78.05%
=======================================
Files 147 147
Lines 5077 5077
=======================================
Hits 3963 3963
Misses 1114 1114 Continue to review full report at Codecov.
|
arturcic
changed the title
|
I think this is the source of the issue https://github.com/GitTools/GitVersion/blob/master/src/GitVersionTask.Tests/Helpers/MsBuildExeFixture.cs#L67 Currently we use nunit 3.12 that does not recognize the .net 5.0 as a valid runtime. There is a PR on nunit to release a new version that does support .net 5.0 nunit/nunit#3666. So when they release it, we can continue |
|
@asbjornu I've download the first successful build. Does it make sense to give it a try or should I wait until anoter clean compile is available? |
|
@digitalsigi, I don't think there's going to happen much here until nunit/nunit#3666 is merged, so please go ahead and test. I would download artifacts from one of the later builds, though; they are available even though the build has failed. |
|
Tested it in my environment: |
|
nunit/nunit#3666 is now merged, perhaps we can try an upgrade and get this thing moving again? |
Well maybe, but verison 3.13 of nunit it was not yet released |
I see. There are no pre-releases we can try either? |
Doesn't seem so... |
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Checklist: